Skip to content

fix(website): display severity source - #5933

Merged
jess-lowe merged 2 commits into
google:masterfrom
ZedingZhang:fix/severity-source-frontend
Sep 2, 2026
Merged

fix(website): display severity source#5933
jess-lowe merged 2 commits into
google:masterfrom
ZedingZhang:fix/severity-source-frontend

Conversation

@ZedingZhang

Copy link
Copy Markdown
Contributor

Overview

Display the optional severity source on vulnerability detail pages so users can distinguish NVD, CNA, and self-attributed assessments.

Fixes #5922

Details

  • Preserve severity source when building the Go website display model.
  • Render the source in both the Go and legacy Jinja vulnerability templates when present.
  • Add an emulator fixture containing a CVSS severity attributed to NVD.
  • Add regression coverage for source propagation while leaving source-less records unchanged.

Testing

  • go test ./internal/website
  • go vet ./internal/website
  • pnpm --dir gcp/website/frontend3 exec webpack --config webpack.dev.js --mode development
  • Validated the updated fixture against osv/osv-schema/validation/schema.json.
  • Parsed the Jinja template with Jinja2.

This contribution was created with AI assistance (OpenAI Codex); the changes and test results were reviewed before submission.

@google-cla

google-cla Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jess-lowe

Copy link
Copy Markdown
Contributor

As the Go website stuff hasn't been merged yet, I'll wait to review this until after that has happened (supposedly Wednesday)

@jess-lowe
jess-lowe self-requested a review September 1, 2026 23:59

@jess-lowe jess-lowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but the testcase may need to be updated in go/cmd/website-devserver/testdata or it's not really visible :) - and also this should probably be rebase/merged with master

@jess-lowe

Copy link
Copy Markdown
Contributor

/gcbrun

@jess-lowe
jess-lowe merged commit 4bb3db8 into google:master Sep 2, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate whether severity.source is supported on the frontend

2 participants